Skip to content

Allow creating IPAddress object from string and provide = overload#174

Merged
facchinm merged 3 commits into
arduino:masterfrom
pennam:ip-string
Dec 21, 2022
Merged

Allow creating IPAddress object from string and provide = overload#174
facchinm merged 3 commits into
arduino:masterfrom
pennam:ip-string

Conversation

@pennam

@pennam pennam commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@pennam pennam requested review from aentinger and facchinm October 12, 2022 10:54
@aentinger aentinger changed the title Allow creating IPAddress object from sting and provide = overload Allow creating IPAddress object from string and provide = overload Oct 12, 2022

@aentinger aentinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pennam

pennam commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

Fixed typo in commit message

Comment thread api/IPAddress.h Outdated
Comment thread api/IPAddress.h Outdated
pennam and others added 2 commits October 14, 2022 16:15
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
@pennam

pennam commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

1 commit 3 typos 😭 thanks @per1234

@facchinm facchinm merged commit 9821ad0 into arduino:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants